I’m in the process of upgrading Tutor to open-release/lilac.master. As usual, I discover a lot of tiny things that need to be modified. I’m using this topic as a brain dump for others to follow my progress. Also, these notes might be useful for others attempting a similar process.
got rid of the pre_common_all.py setting template because we don’t have to ignore deprecation warnings anymore – unless we do?
turns out there are a few deprecation warnings related to etree, but they are not too bad:
2021-04-13 19:23:13,065 WARNING 7 [py.warnings] [user None] [ip None] warnings.py:109 - /openedx/venv/lib/python3.8/site-packages/newrelic/console.py:84: DeprecationWarning: `formatargspec` is deprecated since Python 3.5. Use `signature` and the `Signature` object directly
prototype = wrapper.__name__[3:] + ' ' + inspect.formatargspec(
2021-04-13 19:23:13,203 WARNING 7 [py.warnings] [user None] [ip None] warnings.py:109 - /openedx/edx-platform/lms/djangoapps/course_wiki/plugins/markdownedx/wiki_plugin.py:5: DeprecationWarning: 'etree' is depre
cated. Use 'xml.etree.ElementTree' instead.
from lms.djangoapps.course_wiki.plugins.markdownedx import mdx_mathjax, mdx_video
2021-04-13 19:23:15,447 WARNING 7 [py.warnings] [user None] [ip None] warnings.py:109 - /openedx/venv/src/django-wiki/wiki/plugins/links/wiki_plugin.py:9: DeprecationWarning: 'etree' is deprecated. Use 'xml.etre
e.ElementTree' instead.
from wiki.plugins.links.mdx.djangowikilinks import WikiPathExtension
That’s all we have to do to upgrade edx-platform? That’s surprisingly little.
Aaaah no. There is an Elasticsearch connection error while running tutor local import democourse. That’s because the ELASTIC_SEARCH_CONFIG env token was renamed to ELASTIC_SEARCH_CONFIG_ES7. The funny thing is that the line is prefixed by a comment:
# TODO: Once we have successfully upgraded to ES7, switch this back to ELASTIC_SEARCH_CONFIG.
More issues:
The LMS includes a “View in the new experience” button that links to the learning MFE… which is not enabled yet. Hmm turns out this button is ALWAYS visible for staff users, even if the MFE feature is not enabled: refactor: centralize checks for canonical courseware experience & URL… · edx/edx-platform@9b37e7d · GitHub This is not cool, as the learning MFE will not be part of Lilac. And even if it were, we need to be able to deactivate it.
We need to increase vm.max_map_count on the host. Is this new or is it because I’m running on a new computer? Should all users do this? sudo sysctl -w vm.max_map_count=262144
to run as a single node, we need to pass discovery.type=single-node otherwise we get “the default discovery settings are unsuitable for production use” errors.
the heap size settings must be passed as environment variables.
wtf is Braze? It’s a “customer engagement platform”: https://www.braze.com/ Hmmmm I’m pretty sure I don’t want to use that… Luckily there aren’t too many hits for “braze” in the edx-platform source code. Most of them come from polish translation strings.
But does it mean that we need to configure s3 by default to store course highlights? No, because the EXPORT_COURSE_METADATA_FLAG waffle flag is disabled by default.
There is now a “reindex” button which seems to work – except on the demo course which is missing sjson transcripts, but that’s nothing new.
The Account MFE makes weird calls to http://localhost:18360/demographics/api/v1/demographics/ urls. It seems that this feature is gated by the ENABLE_DEMOGRAPHICS_COLLECTION env setting. I have no idea what this “demographics” backend is supposed to do.
Nope, setting ENABLE_DEMOGRAPHICS_COLLECTION=false does not disable the call to the demographics backend… For that we actually need to set DEMOGRAPHICS_BASE_URL=null.
I can also see that we make calls to http://LMS/api/coaching/v1/users/3/. These calls end in 404. This is because COACHING_ENABLED=true in development (now switching to false).
Well, neither of these work. Is that because these variables are evaluated as process.env.COACHING_ENABLED || false? Maybe we should set these variables to empty strings to disable these features? YES! That did the trick.
