Thanks for the proposal @BbrSofiane!
Yes, exactly. Just implement the “discovery-production-settings” patch.
Hmmm I would tend to disagree. The reason is that most people want to avoid running the discovery service, when possible, for a lighter Open edX platform. This means that we need to know which MFEs actually require the discovery service.
I suggest that you only add the services that you need to the discovery CORS_ORIGIN_WHITELIST
in development mode. When we face a similar issue with other MFEs, we can replicate the same patch.
Well, actually, it seems to me that we already know which services depend on the Discovery service, as indicated by the value of CORS_ORIGIN_WHITELIST in dev mode: course-discovery/course_discovery/settings/devstack.py at 6bc78aafee84306db2f9d136a14205d271ee89ec · openedx/course-discovery · GitHub
CORS_ORIGIN_WHITELIST = (
'localhost:8734', # frontend-app-learner-portal-enterprise
'localhost:18400', # frontend-app-publisher
'localhost:18450', # frontend-app-support-tools
'localhost:2000', # frontend-app-learning
)
As you noticed, the publisher MFE is there, but also the learning MFE. This dependency should thus be indicated in the tutor-mfe README in Maple.
Isn’t this already the case? tutor-discovery/tutordiscovery/templates/discovery/hooks/discovery/init at 89f2dc9ed566953d19cc706191aa6e71cfd94a54 · overhangio/tutor-discovery · GitHub Or do we need to create an extra partner for the MFE? If yes, the publisher MFE should implement the discovery/init hook.
Do you think that the Publisher MFE should be included in the tutor-mfe plugin? In Lilac, Maple or both? If the publisher MFE is not required, it should be installed as a separate plugin or with specific installation instructions in the tutor-mfe plugin. If we must create a separate tutor-publisher plugin, who will maintain it? I can take care of it, but if you would rather maintain it I’ll happily link to it from the Tutor docs.